Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flaky UI Test, for now (see #1482, fixes #2197) #2203

Conversation

vorburger
Copy link
Member

Fixes #2197, see also #1482

Description
This disables a known flaky UI test. This reduces confusion on why PRs fail to build.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
The alternative is to fix the flaky UI test. My Android foo isn't strong enough to know how to do that, unfortunately.

Type
Choose one: Bug fix Feature | Documentation | Testing | Code health | Builds | Releases | Other

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay... i thought i sent this out: but my main comment here is can you try to ignore this only for api level 24? this is not flaky on api level 33.

@vorburger
Copy link
Member Author

sorry for the delay... i thought i sent this out: but my main comment here is can you try to ignore this only for api level 24? this is not flaky on api level 33.

I have no idea if it's possible to (easily) do that. @omarismail94 would you happen to know?

If it's not, my recommendation is to ignore it for all, until fixed, to have green CI.

@omarismail94
Copy link
Contributor

omarismail94 commented Sep 29, 2023

sorry for the delay... i thought i sent this out: but my main comment here is can you try to ignore this only for api level 24? this is not flaky on api level 33.

I have no idea if it's possible to (easily) do that. @omarismail94 would you happen to know?

If it's not, my recommendation is to ignore it for all, until fixed, to have green CI.

In the flaky test, you can add this block:

    @Test
    fun testMethodToIgnoreOnApi24() {
        // Ignore this specific test if the API level is 24
        Assume.assumeTrue(Build.VERSION.SDK_INT != Build.VERSION_CODES.N)
        
        // Your test code here...
    }

https://junit.org/junit4/javadoc/4.13/org/junit/Assume.html#assumeTrue(boolean)

@vorburger
Copy link
Member Author

@vorburger vorburger force-pushed the vorburger-QuestionnaireItemDialogMultiSelectViewHolderFactoryEspressoTest branch 3 times, most recently from 1ed5737 to 72a5eb0 Compare September 29, 2023 16:12
Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorburger can you also add the same thing to:
clickAddAnotherAnswer_shouldScrollDownToShowAddAnotherAnswer

It is the other flaky test this library

@vorburger vorburger force-pushed the vorburger-QuestionnaireItemDialogMultiSelectViewHolderFactoryEspressoTest branch from 72a5eb0 to e390537 Compare October 6, 2023 09:33
@omarismail94 omarismail94 enabled auto-merge (squash) October 6, 2023 09:41
@omarismail94 omarismail94 merged commit 1999e48 into master Oct 6, 2023
3 checks passed
@omarismail94 omarismail94 deleted the vorburger-QuestionnaireItemDialogMultiSelectViewHolderFactoryEspressoTest branch October 6, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

CI is broken and fails for trivial PR
4 participants