Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UploadWorkManager #2166

Merged
merged 9 commits into from
Sep 14, 2023
Merged

Remove UploadWorkManager #2166

merged 9 commits into from
Sep 14, 2023

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Sep 13, 2023 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description

  • Remove UploadWorkManager and its only implementation SquashedChangesUploadWorkManager
  • Inlined UploaderImpl into Uploader which is no longer an interface
  • Move Downloader to the download package

Alternative(s) considered
NA

Type
Code health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 enabled auto-merge (squash) September 13, 2023 10:49
@jingtang10
Copy link
Collaborator Author

@omarismail94 @anchita-g

anchita-g
anchita-g approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@anchita-g anchita-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jingtang10 jingtang10 merged commit f949093 into google:master Sep 14, 2023
2 of 3 checks passed
@jingtang10 jingtang10 deleted the upload branch September 14, 2023 09:01
This was linked to issues Sep 14, 2023
Create new resources on the server using POST #760
Closed
Upload Work Manager - API refactoring #2103
Closed
@jingtang10 jingtang10 mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarismail94 omarismail94 omarismail94 approved these changes

@anchita-g anchita-g anchita-g approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle santosh-pingle is a code owner

@aditya-07 aditya-07 Awaiting requested review from aditya-07 aditya-07 was automatically assigned from google/android-fhir

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload Work Manager - API refactoring Create new resources on the server using POST
3 participants
@jingtang10 @omarismail94 @anchita-g