Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the patient date of birth by 1 year to temporarily fix the test case #2165

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jingtang10
Copy link
Collaborator

#2164

Description
Increase the patient date of birth by 1 year to temporarily fix the test case.

The issue should not be closed as a result of this PR. This is ONLY A TEMPORARY FIX to unblock other PRs.

An immeidate follow up should be written to fix the test case properly.

Alternative(s) considered
I tried using mockk but it didn't work. This is probably because of the java API cql engine uses to retrieve date. We need to try a different method to fix system time.

Type
Testing

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 merged commit e59980e into google:master Sep 12, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants