Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle build tool from 8.0.2 to 8.1.1 #2158

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

jingtang10
Copy link
Collaborator

Description
Update gradle build tool from 8.0.2 t0 8.1.1

Alternative(s) considered
NA

Type
Builds

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using AGP 8.1.1, we can also remove this block of code from our build files:

 {
    compileOptions {
        sourceCompatibility = <MAJOR_JDK_VERSION>
        targetCompatibility = <MAJOR_JDK_VERSION>
    }
}

and just keep:

kotlin {
    jvmToolchain(17)
}

See:
https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support

Can you update the build files as well?

@jingtang10 jingtang10 changed the title Update gradle build tool from 8.0.2 t0 8.1.1 Update gradle build tool from 8.0.2 to 8.1.1 Sep 11, 2023
@jingtang10
Copy link
Collaborator Author

By using AGP 8.1.1, we can also remove this block of code from our build files:

 {
    compileOptions {
        sourceCompatibility = <MAJOR_JDK_VERSION>
        targetCompatibility = <MAJOR_JDK_VERSION>
    }
}

and just keep:

kotlin {
    jvmToolchain(17)
}

See:
https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support

Can you update the build files as well?

This is done ptal

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@omarismail94 omarismail94 merged commit e6ccead into google:master Sep 12, 2023
2 of 3 checks passed
@jingtang10 jingtang10 deleted the gradle branch September 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants