Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create request and patch packages #2147

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Create request and patch packages #2147

merged 2 commits into from
Aug 30, 2023

Conversation

jingtang10
Copy link
Collaborator

Description
Create two packages: upload.request and upload.patch under com.google.android.fhir.sync

  • patch package: code to creation of patches used to generate upload requests
  • request package: code to generate of upload requests

Alternative(s) considered
NA

Type
Code health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 requested review from santosh-pingle and a team as code owners August 29, 2023 15:57
anchita-g
anchita-g approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@anchita-g anchita-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10 jingtang10 enabled auto-merge (squash) August 30, 2023 10:54
aditya-07
aditya-07 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10 jingtang10 merged commit a75b38b into google:master Aug 30, 2023
2 of 3 checks passed
@jingtang10 jingtang10 deleted the upload branch August 30, 2023 12:36
This was linked to issues Sep 14, 2023
Create new resources on the server using POST #760
Closed
Upload Work Manager - API refactoring #2103
Closed
@jingtang10 jingtang10 mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-07 aditya-07 aditya-07 approved these changes

@anchita-g anchita-g anchita-g approved these changes

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle santosh-pingle is a code owner

@omarismail94 omarismail94 Awaiting requested review from omarismail94 omarismail94 was automatically assigned from google/android-fhir

Assignees
No one assigned
Labels
type:code health
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload Work Manager - API refactoring Create new resources on the server using POST
3 participants
@jingtang10 @aditya-07 @anchita-g