Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a LocalChangeFetcher #2135

Merged
merged 18 commits into from
Sep 14, 2023
Merged

Add a LocalChangeFetcher #2135

merged 18 commits into from
Sep 14, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Aug 15, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2103

Description
Clear and concise code change description.

The LocalChangeFetcher is an interface introduced to streamline the process of fetching and iterating through localChanges, possibly sourced from databases, APIs, or other asynchronous sources.

The objective of the interface are:

  • Abstract the logic of selecting local changes into a separate class
  • Providing a flexible mechanism to choose different fetching strategies

To cater to various fetching requirements, an enum named FetchStrategy will be introduced. This enum will define all possible fetching strategies, such as fetching one local change at a time, or all the resources at once

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 changed the title Add a LocalChangeSelector Add a LocalChangeFetcher Aug 16, 2023
@jingtang10
Copy link
Collaborator

updated title after discussion

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks omar - this is great.

only blocking change is in fhir engine impl. other comments optional and can create follow ups.

@omarismail94 omarismail94 enabled auto-merge (squash) September 14, 2023 15:12
@omarismail94 omarismail94 merged commit d639b63 into google:master Sep 14, 2023
3 checks passed
@omarismail94 omarismail94 deleted the camden branch September 18, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Upload Work Manager - API refactoring
4 participants