Add the next button navigation view to a default long scroll

[LZRS]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1764

Description
Adds support for having the bottom navigation buttons as part of the Questionnaire recyclerview, that would ensure the user has viewed all the field items before clicking next

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Detecting scroll to the bottom of the Recyclerview to toggle visibility of the bottom buttons - was not smooth and the bottom buttons were not showing in a predictable manner

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[MJ1998]

@santosh-pingle Since you are looking into this PR, its ready for review.
@LZRS Requesting to confirm and check all the items under checklist in the issue description.

[jingtang10]

@LZRS thanks for this PR - it's a very well written PR!

I want to highlight though in @shelaghm's comment here #1764 (comment) she said My concern with option 1 is hiding/disabling buttons can also lead to user confusion, and I have a preference for keeping paginated navigation buttons anchored and always visible. We have some [design guidelines](https://developers.google.com/open-health-stack/design/data-capture-guideline#navigation_buttons) here with the rationale.

Your PR changes this right? is there an option to keep the current behaviour? if so can you add a video?

[LZRS]

@LZRS thanks for this PR - it's a very well written PR!

I want to highlight though in @shelaghm's comment here #1764 (comment) she said My concern with option 1 is hiding/disabling buttons can also lead to user confusion, and I have a preference for keeping paginated navigation buttons anchored and always visible. We have some [design guidelines](https://developers.google.com/open-health-stack/design/data-capture-guideline#navigation_buttons) here with the rationale.

Your PR changes this right? is there an option to keep the current behaviour? if so can you add a video?

Yeah, the PR changes that. Within the PR, I tried to set it as configurable in the QuestionnaireFragment.Builder with QuestionnaireFragment.Builder#setShowNavigationInDefaultLongScroll

I will attach video for both cases

[LZRS]

Navigation buttons always Visible

Navigation buttons as part of scroll

[jingtang10]

looks good - can you please add tests @LZRS ?

[LZRS]

looks good - can you please add tests @LZRS ?

Cool, I'll add the tests and ping once done

[jingtang10]

Thanks @LZRS again for this. I've updated this PR and done a couple of improvements:

1. removed the unnecessary navigation recycler view. in the case where the navigation controls are floating at the bottom of the screen, they can just be a simple reused layout instead of using a recycler view which is costly.
2. removed the disabled state for pagination controls which I don't think is ever used actually.

I also want to simplify the QuestionnaireNavigationViewUIState class altogether as I find it to be overly complicated.

I'll try to merge this PR asap.

Thanks

[LZRS]

Thanks @LZRS again for this. I've updated this PR and done a couple of improvements:

1. removed the unnecessary navigation recycler view. in the case where the navigation controls are floating at the bottom of the screen, they can just be a simple reused layout instead of using a recycler view which is costly.
2. removed the disabled state for pagination controls which I don't think is ever used actually.

I also want to simplify the QuestionnaireNavigationViewUIState class altogether as I find it to be overly complicated.

I'll try to merge this PR asap.

Thanks

Okay, thanks @jingtang10

[LZRS]

state.bottomNavItems.single() crashes when QuestionnaireFragment.Builder.setShowNavigationInDefaultLongScroll is set to true since it's empty