Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmark to run as instrumentation tests for builds #1999

Merged
merged 31 commits into from
May 22, 2023

Conversation

anchita-g
Copy link
Collaborator

@anchita-g anchita-g commented May 4, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Added benchmark module to run as instrumentation test on FTL

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
NA

Type
Choose one: (Builds)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94
Copy link
Contributor

@anchita-g can you resolve conflicts after your last PR got merged?

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about the build file

benchmark/build.gradle.kts Show resolved Hide resolved
Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about the build file

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb addition @anchita-g !

@omarismail94 omarismail94 enabled auto-merge (squash) May 22, 2023 09:06
@omarismail94 omarismail94 merged commit b2b6dc5 into google:master May 22, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants