Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make boolean type options full screen width while horizont… #1985

Conversation

khyativyasargus
Copy link
Contributor

…ally aligned

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1968

Description
Change the alignment to make boolean type options full screen width while horizontally aligned

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)
Screenshot_20230424_183545

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator

@khyativyasargus
Please also add screenshot(with issue) before making this change just for reference.

@khyativyasargus
Copy link
Contributor Author

khyativyasargus commented Apr 25, 2023

@santosh-pingle Sure.

@santosh-pingle
Copy link
Collaborator

Thanks!
Added few optional comments.
LGTM

@khyativyasargus
Copy link
Contributor Author

@santosh-pingle
Here is the screenshot(with issue)

image

@santosh-pingle santosh-pingle self-requested a review May 3, 2023 05:49
Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingtang10 jingtang10 enabled auto-merge (squash) May 3, 2023 13:03
@jingtang10 jingtang10 merged commit 49290c5 into google:master May 13, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

[SDC] Change the alignment to make boolean type options full screen width
4 participants