Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dateformat text in lowercase for date and dateTime label. #1976

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

santosh-pingle
Copy link
Collaborator

@santosh-pingle santosh-pingle commented Apr 18, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1969

Description

  • Show date pattern text in the lowerCase when get assigned as hint/label for Date and DateTime view.
  • Show date pattern text in the error text in the lowercase when error message get shown.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

@shelaghm
Screenshot 2023-04-18 at 12 51 13 PM
Screenshot 2023-04-18 at 12 50 46 PM

@shelaghm
Copy link

Looks good to me @santosh-pingle Thanks!

…views/factories/DatePickerViewHolderFactory.kt
…views/factories/DatePickerViewHolderFactory.kt
…views/factories/DateTimePickerViewHolderFactory.kt
@jingtang10 jingtang10 enabled auto-merge (squash) April 19, 2023 12:29
@jingtang10 jingtang10 merged commit 67ca247 into google:master Apr 19, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

[SDC] change date format hint to lowercase
4 participants