Fix zip index based mapping issue when unpacking repeat groups #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimoonak
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
allan-on
added a commit
to opensrp/android-fhir
that referenced
this pull request
Apr 17, 2023
- With unmerged PR google#1973 - With unmerged PR #1 - With unmerged PR google#1917
jingtang10
changed the title
jingtang10
changed the title
jingtang10
changed the title
jingtang10
requested changes
Apr 23, 2023
There was a problem hiding this comment.
thanks for this @maimoonak.
about should not modify other items while unpacking repeated groups: i think the test is wrong, the link ids in the questionnaire response should be non-repeated... can you fix please? thanks!
...e/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponses.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
May 3, 2023
.../main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
…extensions/MoreQuestionnaireItemComponents.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1972
Description
The issue is that the zip index mapping for questionnaire and questionnaire-response item can not be used when unpacking the items while generating questionnaire-response. If items before the group are missed due to enablement it just skip the data entered into item embedded into groups.
Alternative(s) considered
zip index mapping for questionnaire and questionnaire-response item can not be used because there could be missing items from questionnaire-response due to enablement condition
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.