Nested questionnaireResponseComponent with enableWhen in repeated group is missing from questionnaire response. #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up is missing from questionnaire response.
Screen.Recording.2023-03-24.at.5.38.18.PM.mov |
|
I am adding end to end android test for this fix, but getting below error when Can we please review the PR? If the Android test gets fixed, I will push the changes; otherwise, I will have a separate PR for this Android test. |
santosh-pingle
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
android test is added. |
jingtang10
requested changes
Mar 29, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Show resolved
Hide resolved
...ture/src/androidTest/java/com/google/android/fhir/datacapture/QuestionnaireUiEspressoTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Apr 5, 2023
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Outdated
Show resolved
Hide resolved
...ture/src/androidTest/java/com/google/android/fhir/datacapture/QuestionnaireUiEspressoTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1895
Description
The questionnaire response contains answers to all selected and enabled questionnaire items. However, when copying the questionnaire response, the use of 'getEnabledResponseItems' fails to copy the selected answers of enabled items.
when the type is a repeated group item, the questionnaireResponseItemParentMap is always empty in the findEnableWhenQuestionnaireResponseItem() API. This is because the buildParentList logic in EnablementEvaluator fails to correctly build the parent list for repeated group items.
Alternative(s) considered
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.