Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draftAnswer to EditTextDecimalViewHolderFactory #1924

Merged
merged 8 commits into from
May 11, 2023
Merged

Add draftAnswer to EditTextDecimalViewHolderFactory #1924

merged 8 commits into from
May 11, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Mar 20, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1923

Description
Add draftAnswer to EditTextDecimalViewHolderFactory

Alternative(s) considered
No

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests

@jingtang10 jingtang10 requested a review from a team as a code owner May 11, 2023 16:27
…views/factories/EditTextDecimalViewHolderFactoryTest.kt
@jingtang10 jingtang10 enabled auto-merge (squash) May 11, 2023 16:52
@jingtang10 jingtang10 merged commit 25bd683 into google:master May 11, 2023
1 of 2 checks passed
@omarismail94 omarismail94 deleted the draftdecimal branch May 12, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditTextDecimalViewHolderFactory does not save draftAnswers
2 participants