Allow DownloadWorkManager to have Bundle based requests along with url based ones. #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther than url based ones
aditya-07
requested review from
deepankarb,
jingtang10,
jjtswan,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
jingtang10
approved these changes
Mar 28, 2023
engine/src/test/java/com/google/android/fhir/sync/download/DownloaderImplTest.kt
Outdated
Show resolved
Hide resolved
engine/src/test-common/java/com/google/android/fhir/resource/TestingUtils.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/remote/RemoteFhirService.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/DownloadWorkManager.kt
Show resolved
Hide resolved
…-07/android-fhir into ak/bundle-based-download-requests
jingtang10
reviewed
Apr 3, 2023
engine/src/main/java/com/google/android/fhir/sync/remote/RemoteFhirService.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/remote/RetrofitBasedRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/remote/RetrofitBasedRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1888
Description
Requesttype toDownloadWorkManagerto support Url and Bundle based download requests.download(Bundle)api inDataSource.DownloaderImpl.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.