Enable bottom container style and behavior customization #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
force-pushed
the
1842-bottom-container-2
branch
from
4d84389
to
a755ee0
Compare
FikriMilano
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
|
@shelaghm fyi |
|
@FikriMilano Great work! |
|
@shelaghm thanks! I'll add that as the default style |
- paddingVertical requires API level 26 (current min is 24). - Added 4dp instead 8dp padding. 4dp results much similar to the design.
…fhir into 1842-bottom-container-2
|
@shelaghm padding fixed!
|
|
Excellent, thank you @FikriMilano |
jingtang10
requested changes
Feb 17, 2023
FikriMilano
requested review from
jingtang10
and removed request for
shelaghm
|
Reviewing pr, thanks! |
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Mar 6, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
FikriMilano
force-pushed
the
1842-bottom-container-2
branch
from
7c73e8a
to
ce2034b
Compare
FikriMilano
requested review from
jingtang10 and
santosh-pingle
and removed request for
jingtang10 and
santosh-pingle
jingtang10
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1842
Description
Alternative(s) considered
Tried to use BottomAppBar and lift on scroll, elevation won't show and no logic to show the divider.
Type
Choose one: Feature
Screenshots (if applicable)
device-2023-02-13-193814.webm
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.