Improve overriding dimens #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
|
@jingtang10 this is ready for review |
jingtang10
requested changes
Feb 14, 2023
datacapture/src/main/res/layout/questionnaire_item_edit_text_multi_line_view.xml
Outdated
Show resolved
Hide resolved
|
@jingtang10 I'll check all dimens and make sure people can override those safely |
- Create new properties to only handle the use case of that property, so people can override the property without affecting other unintended components - Remove un-used properties - Rename old properties - Arrange properties alphabetically
To make sure the margin exist only when there's an image.
FikriMilano
force-pushed
the
1832-override-dimens
branch
from
42d33c0
to
9e748b6
Compare
|
I'll resolve this once I'm back from exam leave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1832
Description
property, so people can override the property without
affecting other unintended UI components
Alternative(s) considered
N/A
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.