Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Builder to Questionnaire Fragment. #1847

Merged
merged 8 commits into from
Feb 14, 2023

Conversation

aditya-07
Copy link
Collaborator

@aditya-07 aditya-07 commented Feb 7, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1848

Description

  1. Added Builder to QuestionnaireFragment so that the application developers don't have to lookup appropriate keys for Bundle args.
  2. Made QuestionnaireFragment closed and added QuestionnaireItemViewHolderFactoryMatchersProvider and QuestionnaireItemViewHolderFactoryMatchersProviderFactory that can now be used by application developers to add custom QuestionnaireItemViewHolderFactory to the questionnaire.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Code health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@aditya-07 aditya-07 enabled auto-merge (squash) February 14, 2023 11:49
@aditya-07 aditya-07 merged commit 5c9a79f into google:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder for Questionnaire Fragment.
3 participants