Attachment widget clear preview if no answer #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemAttachmentViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
Sure. doing test |
…-fix-attachment-widget-clear-preview-if-no-answer
…er' of github.com:opensrp/android-fhir into 1821-bug-fix-attachment-widget-clear-preview-if-no-answer
|
@santosh-pingle kindly do another review |
jingtang10
requested changes
Jan 26, 2023
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemAttachmentViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemAttachmentViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...oid/fhir/datacapture/views/QuestionnaireItemAttachmentPickerViewHolderFactoryEspressoTest.kt
Outdated
Show resolved
Hide resolved
FikriMilano
requested review from
jingtang10 and
santosh-pingle
and removed request for
santosh-pingle and
jingtang10
|
@jingtang10 this is ready for another review |
There was a problem hiding this comment.
thanks! @FikriMilano, it looks ok to me, others can please review it.
...oid/fhir/datacapture/views/QuestionnaireItemAttachmentPickerViewHolderFactoryEspressoTest.kt
Outdated
Show resolved
Hide resolved
...oid/fhir/datacapture/views/QuestionnaireItemAttachmentPickerViewHolderFactoryEspressoTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Thanks @FikriMilano for fixing and thanks @santosh-pingle for taking a look!
jingtang10
deleted the
1821-bug-fix-attachment-widget-clear-preview-if-no-answer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1821
Description
Clear preview if no answer
Alternative(s) considered
N/A
Type
Choose one: Bug fix
Screenshots (if applicable)
device-2023-01-25-152610.webm
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.