added candidateExpression support #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais-vd
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
# Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewItem.kt
omarismail94
reviewed
Jan 4, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewItem.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireItemEditAdapter.kt # datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
|
Hi @omarismail94 feedback resolved and PR is ready for review. |
omarismail94
reviewed
Jan 9, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireItemEditAdapter.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireItemEditAdapter.kt
maimoonak
reviewed
Jan 17, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Apr 23, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # datacapture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireViewItem.kt # datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
jingtang10
approved these changes
Apr 27, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireViewItem.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Apr 27, 2023
...t/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Apr 27, 2023
...t/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
… in candidate-expression test
jingtang10
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1038
Description
added implementation based on #1480 support.
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.