Support definition based extraction for lists with Non - primitive types #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbothe23
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
joiskash
suggested changes
Jan 4, 2023
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Outdated
Show resolved
Hide resolved
omarismail94
reviewed
Jan 4, 2023
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Outdated
Show resolved
Hide resolved
|
LGTM, and will let @jingtang10 give the final approval! Jing - I reviewed the PR and the suggestion I made was to use a method, fhirType(), that works on both primitives and non-primitives |
jingtang10
reviewed
Jan 26, 2023
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/mapping/ResourceMapperTest.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Show resolved
Hide resolved
|
@joiskash @omarismail94 @vbothe23 can you please help addressing my above comments in a follow up cl? |
|
Sure @vbothe23 will do this ASAP. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1769
Description
Issue:
In
addAnswerToListFieldif the answerValue is of non-primitive type then the primitiveValue will be null and app crashes with NullPointerException.Fix:
Added isPrimitiveType check to handle answerValue of primitive and non-primitive types when extracting to list in definition based extraction.
Alternative(s) considered
No
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.