Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Adds Parameters to EvaluateLibrary and Helper functions #1783

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

vitorpamplona
Copy link
Collaborator

  1. Adds a parameter to evaluateLibrary
  2. Adds 3 evaluateLibrary helper functions to avoid passing null in each parameter. .

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

2. Adds 3 evaluateLibrary helper functions to avoid passing null in each parameter. .
Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change @vitorpamplona ! Can we add some small tests to cover these new functions?

@vitorpamplona
Copy link
Collaborator Author

Thanks @omarismail94. Tests added. :)

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vitorpamplona !

@omarismail94 omarismail94 enabled auto-merge (squash) January 4, 2023 15:51
@omarismail94
Copy link
Contributor

@vitorpamplona can you bring your branch in-line with master so the PR gets merged? Thanks!

@omarismail94 omarismail94 merged commit 0ec9496 into google:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants