Change the relation between IG and ResourceMetadata to Many-to-many. Address DB PR review changes. #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ktarasenko
force-pushed
the
ig-db-followup
branch
from
8f87fc7
to
ec17df7
Compare
ktarasenko
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
kevinmost,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
ktarasenko
force-pushed
the
ig-db-followup
branch
from
ec17df7
to
06246a9
Compare
jingtang10
previously requested changes
Jan 10, 2023
.../java/com/google/android/fhir/implementationguide/db/impl/entities/ResourceMetadataEntity.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/implementationguide/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/implementationguide/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
ktarasenko
changed the title
There was a problem hiding this comment.
Nice changes @ktarasenko ! Left a few comments (mostly nits) and questions
...main/java/com/google/android/fhir/implementationguide/db/impl/ImplementationGuideDatabase.kt
Outdated
Show resolved
Hide resolved
.../java/com/google/android/fhir/implementationguide/db/impl/entities/ResourceMetadataEntity.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/implementationguide/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/implementationguide/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/implementationguide/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/implementationguide/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
.../java/com/google/android/fhir/implementationguide/db/impl/entities/ResourceMetadataEntity.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/fhir/implementationguide/db/impl/entities/IgResourceCrossRef.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/fhir/implementationguide/db/impl/dao/ImplementationGuideDao.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/fhir/implementationguide/db/impl/dao/ImplementationGuideDao.kt
Show resolved
Hide resolved
...main/java/com/google/android/fhir/implementationguide/db/impl/ImplementationGuideDatabase.kt
Outdated
Show resolved
Hide resolved
.../java/com/google/android/fhir/implementationguide/db/impl/entities/ResourceMetadataEntity.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/fhir/implementationguide/db/impl/dao/ImplementationGuideDao.kt
Show resolved
Hide resolved
omarismail94
dismissed
jingtang10’s stale review
Comments on Jing's review have been resolved by Kostia. Dismissing to allow this PR to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Switch to many-to-many relationship between IGs and ResourceMetadata to avoid potential duplications if the same resource is contained by multiple IGs.
Followup review changes for #1731
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.