Introduce new QuestionnaireAdapterItem type
#1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinmost
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
jingtang10
approved these changes
Dec 14, 2022
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireAdapterItem.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireAdapterItem.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireItemReviewAdapter.kt
Outdated
Show resolved
Hide resolved
kevinmost
force-pushed
the
km/repeatedGroupsHeader
branch
from
707330f
to
1b9959f
Compare
This is a sealed class that currently only has one subtype, wrapping `QuestionnaireItemViewItem`. More subtypes will be added in the future to support (for example) repeated group headers, allowing us to break from the current 1:1 mapping of question:row in our adapters. `QuestionnaireItemEditAdapter` and `QuestionnaireItemReviewAdapter` were changed to use this new type.
kevinmost
force-pushed
the
km/repeatedGroupsHeader
branch
from
1b9959f
to
c508977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1766
Description
This is a sealed class that currently only has one subtype, wrapping
QuestionnaireItemViewItem.More subtypes will be added in the future to support (for example) repeated group headers, allowing us to break from the current 1:1 mapping of question:row in our adapters.
QuestionnaireItemEditAdapterandQuestionnaireItemReviewAdapterwere changed to use this new type.Alternative(s) considered
Discussed in Eng Weekly, this is the best approach
Type
Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.