Stop validating disabled questions #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
aditya-07,
deepankarb,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Outdated
Show resolved
Hide resolved
|
@omarismail94 @aditya-07 please take another look thanks! |
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/enablement/EnablementEvaluator.kt
Outdated
Show resolved
Hide resolved
stevenckngaa
approved these changes
Dec 16, 2022
kevinmost
pushed a commit
to kevinmost/android-fhir
that referenced
this pull request
Jan 4, 2023
* Stop validating disabled questions * Remove questionnaire from the constructor of enablement evaluator * Fix EnablementEvaluatorTest.kt * Add test case for disabled question * Address comments * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1760
Description
findEnableWhenQuestionnaireResponseItemfrom theQuestionnarieViewModelclass toEnablementEvaluator. This is a better logical separation since that is business logic specific to how enableWhen worksquestionnaireResponseItemPreOrderListandquestionnaireResponseItemParentMapare both moved toEnablementEvaluatortoo.EnablementEvaluatoris no longer anobjectsince it is now specific to a QuestionnaireResponse in order to build the structures required for finding the questionnaire response item that determins the enablement status of another question.QuestionnaireResponseValidatoris now able to useEnablementEvaluatorin its validation.Alternative(s) considered
NA
Type
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.