itemAnswerMedia extension support added for image #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PallaviGanorkar
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
jingtang10
requested changes
Dec 14, 2022
...apture/src/main/java/com/google/android/fhir/datacapture/views/OptionSelectDialogFragment.kt
Show resolved
Hide resolved
jingtang10
requested changes
Jan 4, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/MoreAnswerOptions.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/MoreAnswerOptions.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/MoreAnswerOptions.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/MoreAnswerOptions.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/MoreAnswerOptions.kt
Outdated
Show resolved
Hide resolved
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
.../com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactoryTest.kt
Outdated
Show resolved
Hide resolved
PallaviGanorkar
force-pushed
the
pg/1614_itemAnswerMedia_answerOption_image_support
branch
from
d61277d
to
890f9ef
Compare
jingtang10
approved these changes
Jan 11, 2023
...gle/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactoryEspressoTest.kt
Outdated
Show resolved
Hide resolved
|
@jingtang10 As discussed attaching video for drop down view item selection with AnswerOptionImage DropdownWithAnswerOptionImage.mp4 |
|
@PallaviGanorkar |
|
@santosh-pingle Please find questionnaire for both paginated and default layout having random images for testing. (Please change extension for both files to .json) sample_registration_questionnaire.txt |
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1614
Description
itemAnswerMedia extension support added for image with data field in extension
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.