Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read-only mode in the SDC library #1738

Merged
merged 6 commits into from
Dec 1, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1704

Description
Add read-only mode in the SDC library.

  • introduce a new argument to the questionnaire fragment QuestionnaireFragment.EXTRA_READ_ONLY
  • setting this argument to true while launching the questionnaire fragent will set the questionnaire in read-only mode
  • read-only mode will look like review mode but without the option to edit the answers

Alternative(s) considered
NA

Type
Feature

Screenshots (if applicable)
NA

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean change Jing! Left a few minor comments

@jingtang10
Copy link
Collaborator Author

thanks omar can you take another look?

@jingtang10 jingtang10 assigned omarismail94 and unassigned jingtang10 Dec 1, 2022
@omarismail94 omarismail94 enabled auto-merge (squash) December 1, 2022 15:12
@jingtang10
Copy link
Collaborator Author

thx omar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read-only summary/review page
3 participants