Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the parameterized tests for questionnaire view model #1736

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

jingtang10
Copy link
Collaborator

Description
At the moment all test cases in QuestionnaireViewModel.kt are being run 4 times with the permutations of providing the questionnaire and the questionnaire response using string or URL.

This is highly inefficient and unnecessary. In fact, we only need to have a few test cases to check the mechanism to load the questionnaire and questionnaire response is working with both string and URL. The test cases regarding other parts of the view model logic shouldn't need to be run 4 times each.

Alternative(s) considered
NA

Type
Testing

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 enabled auto-merge (squash) November 29, 2022 18:53
@jingtang10 jingtang10 merged commit 757ba01 into google:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants