Separate the parameterized tests for questionnaire view model #1736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment all test cases in
QuestionnaireViewModel.kt
are being run 4 times with the permutations of providing the questionnaire and the questionnaire response using string or URL.This is highly inefficient and unnecessary. In fact, we only need to have a few test cases to check the mechanism to load the questionnaire and questionnaire response is working with both string and URL. The test cases regarding other parts of the view model logic shouldn't need to be run 4 times each.
Alternative(s) considered
NA
Type
Testing
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.