-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDC: Allow Typing to filter for Dropdown component #1722
Conversation
…n_view.xml. Handled the inputs in QuestionnaireItemDropDownViewHolderFactory.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, google team can review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @nsabale7 !!
Can you add an Espresso Test in QuestionnaireItemDropDownViewHolderFactoryEspressoTest
to assert the number of items in the menu for different scenarios, e.g. no filtering, filtering with results, filtering with no results?
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt
Show resolved
Hide resolved
…7/android-fhir into ns/allow_typing_dropdown
…ns/allow_typing_dropdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change @nsabale7 !
@nsabale7 great work! @jingtang10 One question I have is if the dropdown component always allow people to type to filter or if it is something that is configurable and needs to be activated? Asking so I can document it properly in my design guidelines. |
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemDropDownViewHolderFactory.kt
Show resolved
Hide resolved
it would always allow filtering by typing. |
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
============================================
+ Coverage 41.79% 42.35% +0.56%
Complexity 384 384
============================================
Files 150 150
Lines 5405 5411 +6
Branches 971 973 +2
============================================
+ Hits 2259 2292 +33
+ Misses 2786 2761 -25
+ Partials 360 358 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).*
Fixes #764
Description
This PR allows to filter options based on typing in the dropdown component.
Type
Choose one: Bug fix
Screenshots (if applicable)
dropdown.mp4
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.