Support choice orientation in boolean view.

[santosh-pingle]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1515

Description

• Support choice orientation in boolean view.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct.
• I have read the Contributing page.
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
• I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

[santosh-pingle]

[codecov]

Codecov Report

Merging #1710 (30e79c8) into master (b1c51f2) will increase coverage by 41.65%.
The diff coverage is 34.61%.

❗ Current head 30e79c8 differs from pull request most recent head eb10fb3. Consider uploading reports for the commit eb10fb3 to get more accurate results

@@              Coverage Diff              @@
##             master    #1710       +/-   ##
=============================================
+ Coverage          0   41.65%   +41.65%     
- Complexity        0      377      +377     
=============================================
  Files             0      150      +150     
  Lines             0     5320     +5320     
  Branches          0      959      +959     
=============================================
+ Hits              0     2216     +2216     
- Misses            0     2762     +2762     
- Partials          0      342      +342     

Impacted Files	Coverage Δ
...tionnaireItemBooleanTypePickerViewHolderFactory.kt	50.70% <34.61%> (ø)
...tionnaireItemEditTextMultiLineViewHolderFactory.kt	0.00% <0.00%> (ø)
...ogle/android/fhir/datacapture/DataCaptureConfig.kt	0.00% <0.00%> (ø)
.../java/com/google/android/fhir/search/MoreSearch.kt	80.78% <0.00%> (ø)
...m/google/android/fhir/sync/remote/FhirConverter.kt	0.00% <0.00%> (ø)
...estionnaireItemEditTextStringViewHolderDelegate.kt	0.00% <0.00%> (ø)
...d/fhir/datacapture/utilities/MoreLocalDateTimes.kt	66.66% <0.00%> (ø)
...ttpVerbBasedBundleEntryComponentImplementations.kt	0.00% <0.00%> (ø)
.../QuestionnaireItemDialogSelectViewHolderFactory.kt	79.59% <0.00%> (ø)
...android/fhir/db/impl/entities/LocalChangeEntity.kt	100.00% <0.00%> (ø)
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[aditya-07]

@santosh-pingle Could we not use android:orientation in the RadioGroup?

[santosh-pingle]

@santosh-pingle Could we not use android:orientation in the RadioGroup?

Advantage of having constraintLayout flow is that if views does not get fit on same line then it get wrap on next line.

[aditya-07]

@santosh-pingle Could we not use android:orientation in the RadioGroup?

Advantage of having constraintLayout flow is that if views does not get fit on same line then it get wrap on next line.

Since the boolean view has just two options, do you think overflow will still be an issue?

[santosh-pingle]

@santosh-pingle Could we not use android:orientation in the RadioGroup?

Advantage of having constraintLayout flow is that if views does not get fit on same line then it get wrap on next line.

Since the boolean view has just two options, do you think overflow will still be an issue?

• Considering the local language translation support in future, and translation values does not get fit on the same line, flow will be good option to wrap these options to next line.
• Also changes in layout resource will be consistent with single/multiple view change.
• And it still requires kotlin changes to change the layout parameters of the answer options and set horizontal orientation on radio group.

[aditya-07]

We should also add a unit test to check that choiceOrientation is properly getting applied in the view.

[jingtang10]

@shelaghm fyi

please take a look at the screenshot above

[shelaghm]

@santosh-pingle See below for feedback on how to adjust the padding so that the buttons look more balanced. See screenshot on how to adjust the padding. Otherwise, it looks great to me.

[santosh-pingle]

@santosh-pingle See below for feedback on how to adjust the padding so that the buttons look more balanced. See screenshot on how to adjust the padding. Otherwise, it looks great to me.

@shelaghm

• left edge padding 16 dp is already present.
• top padding not changed
• padding between icon and text is updated to 16 dp
• right edge padding updated to 24 dp

[jingtang10]

thanks @santosh-pingle