-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Implementation guide library module #1686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktarasenko
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
kevinmost,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
October 22, 2022 12:50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me with one comment! Will wait for @jingtang10 to approve
jingtang10
requested changes
Oct 27, 2022
* Crashed Fixed in Quantity Input Widget * reverted unwanted changes * Spotless check applied * remove clear answer from factory Co-authored-by: omarismail <[email protected]>
…ups check api instead of radio button apis (google#1691)
* WIP PR feedback * spotless ran * added test cases for validation util * used fhirpathengine instance from fhir path expression evaluator * updated test cases name and convention * updated test cases name and their convention to look consistent Co-authored-by: Jing Tang <[email protected]>
* Fix Issue google#1638: disable lenient check * add espresso test * add more tests per date field changed
…r minor add-ons (google#1662) * Create CODE_OF_CONDUCT.md * Delete CODE_OF_CONDUCT.md * Create Contributing.md * Delete contributing.md * Update README.md * Update README.md Co-authored-by: Omar Ismail <[email protected]>
) * Scroll down the recyclerview to show the Add answer button. * Address review comments. * Address review comments. * Add flaky flag to retry * update gcloud components as well * remove version flag Co-authored-by: Santosh Pingle <[email protected]> Co-authored-by: Omar Ismail <[email protected]> Co-authored-by: omarismail <[email protected]>
jingtang10
approved these changes
Nov 22, 2022
ktarasenko
changed the title
Add Implementation guide management library module
Add Implementation guide library module
Nov 22, 2022
Co-authored-by: Jing Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce an empty module for Implementation guide management library
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.