Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Implementation guide library module #1686

Merged
merged 17 commits into from
Nov 23, 2022

Conversation

ktarasenko
Copy link
Contributor

@ktarasenko ktarasenko commented Oct 22, 2022

Description
Introduce an empty module for Implementation guide management library

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me with one comment! Will wait for @jingtang10 to approve

implementationguide/proguard-rules.pro Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
PallaviGanorkar and others added 2 commits October 31, 2022 13:30
* Crashed Fixed in Quantity Input Widget

* reverted unwanted changes

* Spotless check applied

* remove clear answer from factory

Co-authored-by: omarismail <[email protected]>
aditya-07 and others added 11 commits November 7, 2022 13:19
* WIP PR feedback

* spotless ran

* added test cases for validation util

* used fhirpathengine instance from fhir path expression evaluator

* updated test cases name and convention

* updated test cases name and their convention to look consistent

Co-authored-by: Jing Tang <[email protected]>
* Fix Issue google#1638: disable lenient check

* add espresso test

* add more tests per date field changed
…r minor add-ons (google#1662)

* Create CODE_OF_CONDUCT.md

* Delete CODE_OF_CONDUCT.md

* Create Contributing.md

* Delete contributing.md

* Update README.md

* Update README.md

Co-authored-by: Omar Ismail <[email protected]>
)

* Scroll down the recyclerview to show the Add answer button.

* Address review comments.

* Address review comments.

* Add flaky flag to retry

* update gcloud components as well

* remove version flag

Co-authored-by: Santosh Pingle <[email protected]>
Co-authored-by: Omar Ismail <[email protected]>
Co-authored-by: omarismail <[email protected]>
buildSrc/src/main/kotlin/Releases.kt Outdated Show resolved Hide resolved
@jingtang10 jingtang10 assigned ktarasenko and unassigned jingtang10 Nov 22, 2022
@ktarasenko ktarasenko changed the title Add Implementation guide management library module Add Implementation guide library module Nov 22, 2022
@ktarasenko ktarasenko enabled auto-merge (squash) November 22, 2022 14:26
@ktarasenko ktarasenko merged commit ce89b23 into google:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants