Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load different profile for definition based extraction #1676

Merged
merged 32 commits into from
Dec 1, 2022
Merged

load different profile for definition based extraction #1676

merged 32 commits into from
Dec 1, 2022

Conversation

PallaviGanorkar
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1659

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@PallaviGanorkar PallaviGanorkar marked this pull request as draft October 19, 2022 08:28
jingtang10
jingtang10 requested changes Nov 2, 2022
View reviewed changes
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/LoadProfileCallback.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/LoadProfileCallback.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/LoadProfileCallback.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
...rc/main/java/com/google/android/fhir/datacapture/mapping/StructureDefinationCanonicalURLs.kt Outdated Show resolved Hide resolved
...rc/main/java/com/google/android/fhir/datacapture/mapping/StructureDefinationCanonicalURLs.kt Outdated Show resolved Hide resolved
...droidTest/java/com/google/android/fhir/datacapture/mapping/ResourceMapperInstrumentedTest.kt Outdated Show resolved Hide resolved
...droidTest/java/com/google/android/fhir/datacapture/mapping/ResourceMapperInstrumentedTest.kt Outdated Show resolved Hide resolved
...droidTest/java/com/google/android/fhir/datacapture/mapping/ResourceMapperInstrumentedTest.kt Outdated Show resolved Hide resolved
@PallaviGanorkar PallaviGanorkar marked this pull request as ready for review November 9, 2022 15:22
jingtang10
jingtang10 requested changes Nov 16, 2022
View reviewed changes
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
...droidTest/java/com/google/android/fhir/datacapture/mapping/ResourceMapperInstrumentedTest.kt Outdated Show resolved Hide resolved
...droidTest/java/com/google/android/fhir/datacapture/mapping/ResourceMapperInstrumentedTest.kt Outdated Show resolved Hide resolved
...droidTest/java/com/google/android/fhir/datacapture/mapping/ResourceMapperInstrumentedTest.kt Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
jingtang10
jingtang10 requested changes Nov 30, 2022
View reviewed changes
...rc/main/java/com/google/android/fhir/datacapture/mapping/StructureDefinitionCanonicalUrls.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt Outdated Show resolved Hide resolved
@jingtang10 jingtang10 enabled auto-merge (squash) December 1, 2022 13:37
PallaviGanorkar and others added 5 commits December 1, 2022 19:12
@jingtang10 jingtang10 merged commit 029577f into google:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

@aditya-07 aditya-07 Awaiting requested review from aditya-07

@deepankarb deepankarb Awaiting requested review from deepankarb

@jjtswan jjtswan Awaiting requested review from jjtswan

@joiskash joiskash Awaiting requested review from joiskash

@kevinmost kevinmost Awaiting requested review from kevinmost

@ktarasenko ktarasenko Awaiting requested review from ktarasenko

@omarismail94 omarismail94 Awaiting requested review from omarismail94

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@stevenckngaa stevenckngaa Awaiting requested review from stevenckngaa

@vvikramraj vvikramraj Awaiting requested review from vvikramraj

@wantingzhang77 wantingzhang77 Awaiting requested review from wantingzhang77

@yigit yigit Awaiting requested review from yigit

Assignees

@PallaviGanorkar PallaviGanorkar

Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
Data Capture Library 1.0.0
Development

Successfully merging this pull request may close these issues.

Support different profile in SDC lib for definition based extraction
3 participants
@PallaviGanorkar @jingtang10 @santosh-pingle