Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper error message added for invalid date format #1618

Conversation

PallaviGanorkar
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1589

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1618 (7a83957) into master (75ac755) will decrease coverage by 1.64%.
The diff coverage is 22.85%.

❗ Current head 7a83957 differs from pull request most recent head d30f74b. Consider uploading reports for the commit d30f74b to get more accurate results

@@             Coverage Diff              @@
##             master    #1618      +/-   ##
============================================
- Coverage     36.75%   35.11%   -1.65%     
+ Complexity      330      309      -21     
============================================
  Files           145      145              
  Lines          4859     4844      -15     
  Branches        867      859       -8     
============================================
- Hits           1786     1701      -85     
- Misses         2837     2921      +84     
+ Partials        236      222      -14     
Impacted Files Coverage Δ
...fhir/datacapture/validation/DateFormatValidator.kt 0.00% <0.00%> (ø)
...e/validation/QuestionnaireResponseItemValidator.kt 0.00% <0.00%> (-100.00%) ⬇️
...hir/datacapture/views/QuestionnaireItemViewItem.kt 42.85% <0.00%> (-1.59%) ⬇️
...uestionnaireItemDateTimePickerViewHolderFactory.kt 56.39% <15.38%> (-2.91%) ⬇️
...ws/QuestionnaireItemDatePickerViewHolderFactory.kt 53.57% <60.00%> (-11.72%) ⬇️
...fhir/datacapture/validation/ConstraintValidator.kt 0.00% <0.00%> (-100.00%) ⬇️
...re/validation/ValueConstraintExtensionValidator.kt 0.00% <0.00%> (-91.67%) ⬇️
...acapture/validation/MaxValueConstraintValidator.kt 0.00% <0.00%> (-75.00%) ⬇️
...acapture/validation/MinValueConstraintValidator.kt 0.00% <0.00%> (-66.67%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PallaviGanorkar
Copy link
Contributor Author

Handling this issue with different approach in other PR. So closing this PR as its no more required

@PallaviGanorkar PallaviGanorkar deleted the pg/1589_proper_error_message_for_invalid_date_format branch September 28, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Date view if typed input is invalid then appropriate error message should be displayed.
1 participant