Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for the FhirOperator test #1602

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

ktarasenko
Copy link
Contributor

@ktarasenko ktarasenko commented Sep 12, 2022

Fix the test data, while searching how to fix the test in a sustainable way.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1602 (5b5bb4c) into master (aeb5259) will increase coverage by 0.22%.
The diff coverage is 84.86%.

@@             Coverage Diff              @@
##             master    #1602      +/-   ##
============================================
+ Coverage     76.53%   76.76%   +0.22%     
- Complexity      815      844      +29     
============================================
  Files           141      144       +3     
  Lines          4663     4808     +145     
  Branches        850      870      +20     
============================================
+ Hits           3569     3691     +122     
- Misses          623      636      +13     
- Partials        471      481      +10     
Impacted Files Coverage Δ
...e/views/QuestionnaireItemGroupViewHolderFactory.kt 64.70% <ø> (ø)
...gle/android/fhir/datacapture/MoreQuestionnaires.kt 72.22% <50.00%> (-2.78%) ⬇️
...hir/datacapture/MoreQuestionnaireItemComponents.kt 83.15% <66.66%> (-0.72%) ⬇️
...d/fhir/datacapture/fhirpath/ExpressionEvaluator.kt 78.65% <78.65%> (ø)
...ws/QuestionnaireItemDatePickerViewHolderFactory.kt 63.30% <80.00%> (+2.69%) ⬆️
...datacapture/fhirpath/FHIRPathEngineHostServices.kt 90.00% <90.00%> (ø)
...uestionnaireItemDateTimePickerViewHolderFactory.kt 77.90% <91.30%> (+1.74%) ⬆️
...r/datacapture/views/QuestionnaireItemHeaderView.kt 95.45% <92.85%> (+4.54%) ⬆️
...android/fhir/datacapture/QuestionnaireViewModel.kt 81.81% <100.00%> (+0.67%) ⬆️
...acapture/views/QuestionnaireGroupTypeHeaderView.kt 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jingtang10 jingtang10 merged commit 626dd68 into google:master Sep 13, 2022
@ktarasenko ktarasenko deleted the kt/fix_fhir_operator_test branch September 13, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants