Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set answer properly to radio button input #1573

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Set answer properly to radio button input #1573

merged 4 commits into from
Sep 9, 2022

Conversation

PallaviGanorkar
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1521

Description
answersChangedCallback was not called as local variable of class QuestionnaireItemViewItem "answers" was updated incorrectly.
Now updated "answers" field by using setAnswer() method to fix it

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@fredhersch
Copy link
Collaborator

@aditya-07 can you review this?

@aditya-07 aditya-07 self-assigned this Aug 30, 2022
@aditya-07 aditya-07 added type:bug Something isn't working Data capture labels Aug 30, 2022
@jingtang10 jingtang10 assigned jingtang10 and unassigned aditya-07 Sep 9, 2022
@PallaviGanorkar PallaviGanorkar changed the title Pg/1521 radio button input reset answer paginated layout Radio button input reset answer in paginated layout Sep 9, 2022
@PallaviGanorkar PallaviGanorkar changed the title Radio button input reset answer in paginated layout Set answer properly to radio button input Sep 9, 2022
@jingtang10 jingtang10 merged commit 29fde51 into google:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

@aditya-07 aditya-07 Awaiting requested review from aditya-07

@jjtswan jjtswan Awaiting requested review from jjtswan

@joiskash joiskash Awaiting requested review from joiskash

@kevinmost kevinmost Awaiting requested review from kevinmost

@omarismail94 omarismail94 Awaiting requested review from omarismail94

@stevenckngaa stevenckngaa Awaiting requested review from stevenckngaa

@vvikramraj vvikramraj Awaiting requested review from vvikramraj

@wantingzhang77 wantingzhang77 Awaiting requested review from wantingzhang77

@yigit yigit Awaiting requested review from yigit

Assignees

@jingtang10 jingtang10

Labels
type:bug Something isn't working
Projects
Android FHIR SDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choice with Radio Button input resets answer in paginated layout.
4 participants
@PallaviGanorkar @fredhersch @jingtang10 @aditya-07