Added HttpLogger as a configuration for FhirEngine. #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-07
requested review from
jingtang10,
jjtswan,
kevinmost,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
joiskash
approved these changes
Sep 13, 2022
engine/src/main/java/com/google/android/fhir/sync/remote/FhirHttpLogger.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
============================================
- Coverage 36.54% 36.36% -0.18%
Complexity 330 330
============================================
Files 147 149 +2
Lines 4923 4947 +24
Branches 877 879 +2
============================================
Hits 1799 1799
- Misses 2886 2910 +24
Partials 238 238
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jingtang10
requested changes
Sep 21, 2022
engine/src/main/java/com/google/android/fhir/sync/remote/RemoteFhirService.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/FhirEngineProvider.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/FhirEngineProvider.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Sep 27, 2022
engine/src/test/java/com/google/android/fhir/sync/remote/MoreHttpLoggerKtTest.kt
Outdated
Show resolved
Hide resolved
joiskash
approved these changes
Sep 30, 2022
engine/src/test/java/com/google/android/fhir/sync/remote/MoreHttpLoggerKtTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Sep 30, 2022
engine/src/main/java/com/google/android/fhir/sync/remote/MoreHttpLogger.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/remote/FhirHttpLogger.kt
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/google/android/fhir/sync/remote/MoreHttpLoggerKtTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1426
Description
Issue:
There is no way for clients to listen / log the Http communication between engine and server.
Solution:
Added
HttpLoggeras part of server configuration of the FhirEngine to be specified by the developer application. TheHttpLoggertakes a lambda that is called with the log message based on the loggingHttpLogger.Levelspecified by the application as part ofHttpLogger.ConfigurationAlternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.