Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant tests in catalog module #1540

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Remove redundant instrumentation tests in catalog module

Alternative(s) considered
NA

Type
Testing

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I checked if we reference the test anywhere and we do here:

Can you remove this line as well?

@jingtang10
Copy link
Collaborator Author

Nice! I checked if we reference the test anywhere and we do here:

Can you remove this line as well?

should we keep this so that if/when we add the workflow tests they'll just get executed?

@omarismail94
Copy link
Contributor

Sorry, I meant we should get rid of this line

            ./gradlew :catalog:connectedCheck  --stacktrace --scan

because there is no longer any tests under catalog

@jingtang10
Copy link
Collaborator Author

Sorry, I meant we should get rid of this line

            ./gradlew :catalog:connectedCheck  --stacktrace --scan

because there is no longer any tests under catalog

done. thanks!

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jingtang10 jingtang10 merged commit 5095ba2 into google:master Aug 8, 2022
@jingtang10 jingtang10 deleted the redundant-test branch August 8, 2022 16:03
@aditya-07 aditya-07 added Reference app type:testing Improvements on tests or testing infrastructure type:code health labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code health type:testing Improvements on tests or testing infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants