Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case Sleep time increased for sync time update in hamburger menu #1355

Merged
merged 21 commits into from
Jun 1, 2022

Conversation

PallaviGanorkar
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1135

Description
Sleep Time updated for failing test case

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1355 (83f468e) into master (f843f33) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1355      +/-   ##
============================================
- Coverage     85.72%   85.68%   -0.04%     
  Complexity      716      716              
============================================
  Files           149      149              
  Lines         10760    10765       +5     
  Branches        858      858              
============================================
  Hits           9224     9224              
- Misses         1095     1100       +5     
  Partials        441      441              
Impacted Files Coverage Δ
.../android/fhir/datacapture/QuestionnaireFragment.kt 9.37% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da37881...83f468e. Read the comment docs.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready for review? have you tested 2000, 3000, 4000 etc? why this number?

@PallaviGanorkar PallaviGanorkar marked this pull request as draft May 13, 2022 12:27
@jingtang10
Copy link
Collaborator

closing test draft pr.

@jingtang10 jingtang10 closed this Jun 1, 2022
@jingtang10 jingtang10 reopened this Jun 1, 2022
@jingtang10 jingtang10 marked this pull request as ready for review June 1, 2022 14:44
@jingtang10 jingtang10 enabled auto-merge (squash) June 1, 2022 14:45
@jingtang10 jingtang10 merged commit c58894d into master Jun 1, 2022
@jingtang10 jingtang10 deleted the pg/1135-SyncTimeNotUpdated branch June 1, 2022 15:45
@Tarun-Bhardwaj Tarun-Bhardwaj added type:bug Something isn't working FHIR engine P2 Medium priority issue labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority issue type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sync time is not updating in hamburger menu after manual sync with server and toast message shows older time
3 participants