Upgrading JUnit #1342
Upgrading JUnit #1342
Conversation
vitorpamplona
requested review from
aditya-07,
jingtang10,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
| const val core = "1.4.1-alpha05" | ||
| const val archCore = "2.1.0" | ||
| const val extJunit = "1.1.3" | ||
| const val rules = "1.4.0" | ||
| const val runner = "1.4.0" | ||
| const val extJunit = "1.1.4-alpha05" | ||
| const val rules = "1.4.1-alpha05" | ||
| const val runner = "1.5.0-alpha02" |
There was a problem hiding this comment.
4.13 is not available for non-alpha versions yet. Should we wait?
There was a problem hiding this comment.
All up-to-date. Should we ship with alpha testing libs? I don't see a big issue with it.
There was a problem hiding this comment.
i don't feel this ticket is a priority any more given that we resolved the dependency issue of the common lib. based on that i don't feel there's a rush to upgrade junit to 4.13. we should wait a little bit.
There was a problem hiding this comment.
when will we be able to use 4.13 with non-alpha versions of other libs
There was a problem hiding this comment.
Agree, it's not urgent. The major goal for the upgrade is to get the method assertThrows on unit tests. It's useful because the engine throws an exception on read(id) if it can't find the object (as opposed to returning null).
Today, we have to use this verbose version:
assertThat(runCatching { provider.cleanup() }.exceptionOrNull())
.isInstanceOf(IllegalStateException::class.java)There was a problem hiding this comment.
i'm very surprised using public version 4.13 of junit requires using alpha versions of other libs... this seems totally wrong. is there any documentation on this? any one raised any issues?
There was a problem hiding this comment.
I am not sure why it surprises you. 4.13 is a somewhat new version. The majority of AndroidX test libs are still on 4.12.
| const val fragmentVersion = "1.3.6" | ||
| } | ||
|
|
||
| const val espresso = "3.4.0" | ||
| const val espresso = "3.5.0-alpha05" |
|
Hi @vitorpamplona - can you please update this PR now that #1353 is merged? Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
=============================================
+ Coverage 75.22% 89.91% +14.69%
+ Complexity 650 648 -2
=============================================
Files 128 129 +1
Lines 3943 9874 +5931
Branches 721 721
=============================================
+ Hits 2966 8878 +5912
- Misses 591 608 +17
- Partials 386 388 +2
Continue to review full report at Codecov.
|
# Conflicts: # buildSrc/src/main/kotlin/Dependencies.kt
|
closing this due to it being very old. vitor please feel free to update and reopen. i'll also try to handle this update in my hapi upadte pr #1616 |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1341
Description
Upgrade of JUnit and testing dependencies to 4.13
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.