Update the UI using the answers in the view model #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
deepankarb,
pankajkatoch and
yigit
as code owners
jingtang10
force-pushed
the
jt/sdc-set-values
branch
from
db8751c
to
c84e1b5
Compare
yigit
reviewed
Jan 6, 2021
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemCheckBoxViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...java/com/google/android/fhir/datacapture/views/QuestionnaireItemCheckBoxViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
thanks yigit :) ptal! |
yigit
reviewed
Jan 6, 2021
| ) | ||
| ) { | ||
| var singleAnswerOrNull | ||
| get() = questionnaireResponseItemComponent.answer.singleOrNull() |
There was a problem hiding this comment.
not sure if you meant this but singleOrNull returns null if there are more than 1 items:
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/single-or-null.html
There was a problem hiding this comment.
I think basically there's something really wrong if we have multiple answers here. I'm happy with this rather lenient method rather than throwing exception or returning first.
There was a problem hiding this comment.
might be good to add a comment here to specify it is intentional.
yigit
approved these changes
Jan 6, 2021
| ) | ||
| ) { | ||
| var singleAnswerOrNull | ||
| get() = questionnaireResponseItemComponent.answer.singleOrNull() |
| ) | ||
| ) { | ||
| var singleAnswerOrNull | ||
| get() = questionnaireResponseItemComponent.answer.singleOrNull() |
There was a problem hiding this comment.
might be good to add a comment here to specify it is intentional.
joiskash
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had not implemented this because we assumed that it's ok to render the UI without providing an initial value until we implement the initial value to the SDC specification.
However, this already caused issue because the recycler view reuses the questionnaire item views, and if we don't try to set the answer the view might still carry what the user had input for a different question.