Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDC library widget tests use Robolectric #1332

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1330

Description
Make SDC library widget tests use Robolectric

Alternative(s) considered
NA

Type
Testing

Screenshots (if applicable)
NA

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing code is the best type of code!

@omarismail94 omarismail94 enabled auto-merge (squash) April 26, 2022 17:14
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1332 (d43c3ad) into master (13aa710) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1332   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
  Complexity      687      687           
=========================================
  Files           148      148           
  Lines         10701    10701           
  Branches        832      832           
=========================================
  Hits           9050     9050           
  Misses         1237     1237           
  Partials        414      414           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13aa710...d43c3ad. Read the comment docs.

@omarismail94 omarismail94 merged commit 6f4a654 into google:master Apr 28, 2022
@jingtang10 jingtang10 deleted the espresso-tests branch April 28, 2022 08:07
@Tarun-Bhardwaj Tarun-Bhardwaj added type:testing Improvements on tests or testing infrastructure Data capture labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:testing Improvements on tests or testing infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move sdc library widget tests from instrumentation tests to robolectric tests
3 participants