Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable QuestionnaireItemDropDownViewHolderFactoryEspressoTest #1324

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Apr 22, 2022

QuestionnaireItemDropDownViewHolderFactoryEspressoTest#shouldSetDropDownValueToAutoCompleteTextView

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1323

Description

  • Temporarily disable QuestionnaireItemDropDownViewHolderFactoryEspressoTest#shouldSetDropDownValueToAutoCompleteTextView
  • Improve imports
  • Use property access syntax
  • Remove unnecessary explicit type arguments

Alternative(s) considered
NA

Type
Testing

Screenshots (if applicable)
NA

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! One nit: can you update title to include making Android Studio suggested changes?

@omarismail94 omarismail94 enabled auto-merge (squash) April 22, 2022 16:50
@jingtang10 jingtang10 changed the title Temporarily ignore QuestionnaireItemDropDownViewHolderFactoryEspressoTest Temporarily disable QuestionnaireItemDropDownViewHolderFactoryEspressoTest Apr 22, 2022
@jingtang10
Copy link
Collaborator Author

Approved! One nit: can you update title to include making Android Studio suggested changes?

thanks - i think the other changes are just cosmetic and less important. so kept the title the same, but added them in the description.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1324 (157cf56) into master (ae4c26a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #1324   +/-   ##
=========================================
  Coverage     84.50%   84.51%           
  Complexity      686      686           
=========================================
  Files           148      148           
  Lines         10697    10697           
  Branches        832      833    +1     
=========================================
+ Hits           9040     9041    +1     
+ Misses         1244     1240    -4     
- Partials        413      416    +3     
Impacted Files Coverage Δ
...iews/QuestionnaireItemDropDownViewHolderFactory.kt 54.28% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9539332...157cf56. Read the comment docs.

@omarismail94 omarismail94 merged commit 04994e6 into google:master Apr 22, 2022
@Tarun-Bhardwaj Tarun-Bhardwaj added type:testing Improvements on tests or testing infrastructure Data capture labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:testing Improvements on tests or testing infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DropDown widget Espresso tests flaky
5 participants