-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and moved Date and Time pickers to material #1312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
============================================
+ Coverage 83.72% 83.96% +0.24%
+ Complexity 690 687 -3
============================================
Files 148 148
Lines 10708 10694 -14
Branches 836 846 +10
============================================
+ Hits 8965 8979 +14
+ Misses 1340 1310 -30
- Partials 403 405 +2
Continue to review full report at Codecov.
|
@santosh-pingle can you please leave a review |
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code owner please review it, thanks!
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/QuestionnaireItemDatePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...om/google/android/fhir/datacapture/views/QuestionnaireItemDateTimePickerViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
val date = Date.from(atZone(ZoneId.systemDefault()).toInstant()) | ||
return DateFormat.getTimeFormat(context).format(date) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should just call the function in MoreLocalTimes.kt
?
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
QuestionnaireItemDatePickerViewHolderFactory
.QuestionnaireItemDateTimePickerViewHolderFactory
and cleaned up code as well.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Code health
Screenshots (if applicable)
Date-Time-Picker-Material.mov
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.