Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Showing no validation errors when form opens #1309

Merged
merged 101 commits into from
May 23, 2022
Merged

Fixed Showing no validation errors when form opens #1309

merged 101 commits into from
May 23, 2022

Conversation

aurangzaibumer
Copy link
Collaborator

@aurangzaibumer aurangzaibumer commented Apr 19, 2022 •
edited
Loading

Fixes
#1001 #opensrp/fhircore#873

Description
The validation will not be triggered if the answers are empty or User hasn't made interaction with the input field yet whenever form opens. However the validation will be triggered if you open questionnaire with pre-defined answers since the condition checks if the answers are there or not.

Type
Choose one: ( Bug fix)

Screenshots (if applicable)
https://user-images.githubusercontent.com/35099184/152525877-d7d52896-3063-4925-903e-159a34d86a32.mp4

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

aurangzaibumer and others added 30 commits February 1, 2022 14:55
@aurangzaibumer
[1001] removed validation from bind
3b79082
@aurangzaibumer
issue [1001] removed validation from bind view of list
eeaa485
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
1b676ac
@aurangzaibumer
spotless ran
1b27b55
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
03799de 
…android-fhir into 1001-fix-form-validation
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
40ba1f8
@aurangzaibumer
added new implementation and fixed test cases
978e205
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
85f97f4 
…android-fhir into 1001-fix-form-validation
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
4be9813
@aurangzaibumer
implementation changed
38db22d
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
5851824 
…android-fhir into 1001-fix-form-validation
@aurangzaibumer
test case fixed
49f66bf
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
36cc9e3
@aurangzaibumer
spotless checks fixed
4952c7c
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
3cee530 
…android-fhir into 1001-fix-form-validation
@aurangzaibumer
test case fixed
505cc9d
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
c2c48ba
@aurangzaibumer
test case fixed
1d5a948
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
0434601
@f-odhiambo
Merge branch 'master' into 1001-fix-form-validation
c5c7d67
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
a2ebd24 
…android-fhir into 1001-fix-form-validation
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
c956902
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
25de7e8 
…android-fhir into 1001-fix-form-validation
@aurangzaibumer
WIP validation
91c020d
@jingtang10
wip
a8ebdb9
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
20d1813
@aurangzaibumer
completed discussed changes on request validator
dd74225
@aurangzaibumer
Merge branch 'master' into 1001-fix-form-validation
a54d569
@aurangzaibumer
test cases fixed
b4bfd9d
@aurangzaibumer
Merge branch '1001-fix-form-validation' of https://github.com/google/…
4659f24 
…android-fhir into 1001-fix-form-validation
@Tarun-Bhardwaj
Copy link

@jingtang10 , would you be able to review this PR?

jingtang10
jingtang10 requested changes May 17, 2022
View reviewed changes
...m/google/android/fhir/datacapture/views/QuestionnaireItemEditTextStringViewHolderDelegate.kt Outdated Show resolved Hide resolved
...rc/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewHolderFactory.kt Outdated Show resolved Hide resolved
...rc/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewHolderFactory.kt Outdated Show resolved Hide resolved
demo/src/main/assets/new-patient-registration-paginated.json Outdated Show resolved Hide resolved
...e/android/fhir/datacapture/views/QuestionnaireItemEditTextSingleLineViewHolderFactoryTest.kt Outdated Show resolved Hide resolved
...le/android/fhir/datacapture/views/QuestionnaireItemEditTextMultiLineViewHolderFactoryTest.kt Outdated Show resolved Hide resolved
...rc/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewHolderFactory.kt Show resolved Hide resolved
jingtang10
jingtang10 requested changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good - almost ready to merge

last thing - just add some test cases where you have changed the existing test cases by adding modified = true. just make sure that if modify is false, we're not showing validation errors. that's the whole point of this PR now.

...rc/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewHolderFactory.kt Outdated Show resolved Hide resolved
@aurangzaibumer
Copy link
Collaborator Author

looks pretty good - almost ready to merge

last thing - just add some test cases where you have changed the existing test cases by adding modified = true. just make sure that if modify is false, we're not showing validation errors. that's the whole point of this PR now.

added the unit test cases for modify = false. Please review. Thanks

@aurangzaibumer
Copy link
Collaborator Author

aurangzaibumer commented May 23, 2022 •
edited
Loading

looks pretty good - almost ready to merge
last thing - just add some test cases where you have changed the existing test cases by adding modified = true. just make sure that if modify is false, we're not showing validation errors. that's the whole point of this PR now.

added the unit test cases for modify = false. Please review. Thanks

PR gateways passed.
cc @jingtang10 @f-odhiambo

jingtang10
jingtang10 approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small nits

thanks for this!

...rc/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewHolderFactory.kt Outdated Show resolved Hide resolved
...rc/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewHolderFactory.kt Outdated Show resolved Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemViewItem.kt Outdated Show resolved Hide resolved
.../test/java/com/google/android/fhir/datacapture/validation/RequiredConstraintValidatorTest.kt Outdated Show resolved Hide resolved
aurangzaibumer and others added 6 commits May 23, 2022 18:33
@jingtang10 jingtang10 enabled auto-merge (squash) May 23, 2022 13:50
@aurangzaibumer
Copy link
Collaborator Author

A 503 status code has been received, will attempt to retry the upload

Begin Diagnostic HTTP information

Status Code: 503
Status Message: Service Unavailable

@jingtang10 jingtang10 merged commit d93ca2e into google:master May 23, 2022
@aurangzaibumer aurangzaibumer mentioned this pull request May 25, 2022
Closed
@jingtang10 jingtang10 linked an issue Jun 16, 2022 that may be closed by this pull request
Response validation occurs before data entry #1001
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 approved these changes

@aditya-07 aditya-07 Awaiting requested review from aditya-07

@kevinmost kevinmost Awaiting requested review from kevinmost

@ktarasenko ktarasenko Awaiting requested review from ktarasenko

@stevenckngaa stevenckngaa Awaiting requested review from stevenckngaa

@vvikramraj vvikramraj Awaiting requested review from vvikramraj

@yigit yigit Awaiting requested review from yigit

@omarismail94 omarismail94 Awaiting requested review from omarismail94

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@wantingzhang77 wantingzhang77 Awaiting requested review from wantingzhang77

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response validation occurs before data entry
6 participants
@aurangzaibumer @jingtang10 @santosh-pingle @Tarun-Bhardwaj @f-odhiambo @ndegwamartin