Create QuestionnaireItemHeaderView for the common question header (prefix+question+hint) #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
============================================
+ Coverage 84.15% 84.61% +0.45%
- Complexity 678 684 +6
============================================
Files 147 148 +1
Lines 10738 10677 -61
Branches 883 825 -58
============================================
- Hits 9037 9034 -3
+ Misses 1235 1234 -1
+ Partials 466 409 -57
Continue to review full report at Codecov.
|
santosh-pingle
approved these changes
Apr 18, 2022
ktarasenko
approved these changes
Apr 18, 2022
...hir/datacapture/views/QuestionnaireItemBooleanTypePickerViewHolderFactoryInstrumentedTest.kt
Outdated
Show resolved
Hide resolved
| private var hint: TextView = findViewById(R.id.hint) | ||
|
|
||
| fun bind(questionnaireItem: Questionnaire.QuestionnaireItemComponent) { | ||
| questionnaireItem.localizedPrefixSpanned.also { |
There was a problem hiding this comment.
that's a misuse of also instead of declare a variable + if
If you lean to use scope function here, i'd suggest run or maybe 'let'
There was a problem hiding this comment.
changed it to let.
actually i have been wondering myself the case for using scope function vs declaring variables. any more insight into pros and cons of these two approache regarding readability?
...pture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemHeaderView.kt
Outdated
Show resolved
Hide resolved
jingtang10
force-pushed
the
subtitle-space
branch
from
304bc3c
to
433c528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1291
Description
Extract common view for question headers.
Additional refactoring:
EXTENSION_***_UNOFFICIALtoEXTENSION_***_ANDROID_FHIRQuestionnaire.QuestionnaireItemComponent.subtitleTexttoQuestionnaire.QuestionnaireItemComponent.localizedHintSpannedbecause it's localized and hint is slightly more accurate than subtitleQuestionnaire.QuestionnaireItemComponent.flyOverTexttoQuestionnaire.QuestionnaireItemComponent.localizedFlyoverSpannedbecause it's localizedAlternative(s) considered
NA
Type
Bug fix + Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.