Refactor the DownloadManager interface #1266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Refactor the
DownloadManager
interface:DownloadWorkManager
to signify that it only handles a single "download job" and needs to be reset/recreated before the next download job (to be clarified).DownloadWorkManager
. In other words, theDownloadWorkManager
acts as an iterator that provides the URL for the next download request.extractResourcesFromResponse
andextractNextUrlsFromResource
into a singleprocessResponse
function.createDownloadUrl
function as a utility function outside of the interface because it is something that is universal to FHIR requests and not tied down to any single implementation of the `DownloadWorkManager.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.