Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI #1263

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Optimize CI #1263

merged 5 commits into from
Apr 13, 2022

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Mar 26, 2022

Simplify CI cache:

  1. By caching the AVD, we avoid creating a new AVD for each of the instrumentation test steps. An example of this is here
  2. Using Gradle Build Action avoids the need to use the cache step ourselves. See here for details

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #1263 (8c1b002) into master (08c7d23) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1263   +/-   ##
=========================================
  Coverage     84.17%   84.17%           
  Complexity      678      678           
=========================================
  Files           147      147           
  Lines         10735    10735           
  Branches        882      882           
=========================================
  Hits           9036     9036           
  Misses         1233     1233           
  Partials        466      466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c7d23...8c1b002. Read the comment docs.

@jingtang10
Copy link
Collaborator

adding @florina-muntenescu who authored the caching mechanism in case she has anything to add. Thanks @florina-muntenescu and @omarismail94.

@jingtang10
Copy link
Collaborator

@omarismail94 can you please elaborate the intended effects of this optimization?

@omarismail94
Copy link
Contributor Author

@omarismail94 can you please elaborate the intended effects of this optimization?

Yeah, there are two

  1. By caching the AVD, it avoids creating a new AVD for each of the instrumentation test steps. An example of this is here
  2. Using Gradle Build Action avoids the need to use the cache step ourselves. See here for details

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready to go? looks good to me.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jingtang10 jingtang10 merged commit 6fc6099 into master Apr 13, 2022
@jingtang10 jingtang10 deleted the oi/cache branch April 13, 2022 07:39
@aditya-07 aditya-07 added the type:build Issues related to code build label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build Issues related to code build
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants