Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pipeline #1255

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Fix CI pipeline #1255

merged 1 commit into from
Mar 23, 2022

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented Mar 23, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1254

Description
Split instrumentation test into smaller pieces (one for each lib) to avoid timeout

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
See #1254 for different options to get to problem

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1255 (614f51d) into master (63accbf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1255   +/-   ##
=========================================
  Coverage     84.55%   84.55%           
  Complexity      658      658           
=========================================
  Files           141      141           
  Lines         10522    10522           
  Branches        801      801           
=========================================
  Hits           8897     8897           
  Misses         1225     1225           
  Partials        400      400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b79db7...614f51d. Read the comment docs.

Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Omar! LGTM!

@omarismail94 omarismail94 merged commit ffacaea into master Mar 23, 2022
@omarismail94 omarismail94 deleted the oi/ci branch March 23, 2022 06:35
with:
distribution: temurin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any documentation on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I left this in when I was experimenting with caches. I wanted to try out this Grade cache method
https://github.com/gradle/gradle-build-action

as an alternative to our current cache method. One of the requirements was using the actions/setup-java@v2 action which required the distribution name to be defined. What are your thoughts on the action method I linked to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI Pipeline Fails
3 participants