-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1083 973 date picker pop issues fixed #1216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
============================================
+ Coverage 83.92% 84.51% +0.58%
+ Complexity 678 658 -20
============================================
Files 147 140 -7
Lines 10622 10533 -89
Branches 844 803 -41
============================================
- Hits 8915 8902 -13
+ Misses 1271 1228 -43
+ Partials 436 403 -33
Continue to review full report at Codecov.
|
@santosh-pingle can you take a look at this first? thanks |
looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some screenshots?
Added comments, please see whether those can be addressed.
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/utilities/MoreLocalDate.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
Added screen shot |
Done with first review, looks ok to me. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the 3 changes in the PR description, 1 and 2 can probably be grouped in this PR. But please raise a different PR for 3. thanks!
As per comment crate two separate PR for this change |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1083 #973
Description
code changes covers below ,
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.