Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1083 973 date picker pop issues fixed #1216

Closed
wants to merge 13 commits into from

Conversation

PallaviGanorkar
Copy link
Contributor

@PallaviGanorkar PallaviGanorkar commented Mar 2, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1083 #973

Description
code changes covers below ,

  1. Date and time picker widget will be opened only on click of icon on right side in date and time input widget.
  2. user is able to enter date and time using keyboard as well on click of input widget.
  3. For date input widget, helper text is show from json if available otherwise show date format based on device locale as helper text

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@PallaviGanorkar PallaviGanorkar changed the title 1083 973 date picker pop 1083 973 date picker pop issues fixed Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1216 (97ed016) into master (5273132) will increase coverage by 0.58%.
The diff coverage is 20.83%.

❗ Current head 97ed016 differs from pull request most recent head 59c204e. Consider uploading reports for the commit 59c204e to get more accurate results

@@             Coverage Diff              @@
##             master    #1216      +/-   ##
============================================
+ Coverage     83.92%   84.51%   +0.58%     
+ Complexity      678      658      -20     
============================================
  Files           147      140       -7     
  Lines         10622    10533      -89     
  Branches        844      803      -41     
============================================
- Hits           8915     8902      -13     
+ Misses         1271     1228      -43     
+ Partials        436      403      -33     
Impacted Files Coverage Δ
...hir/datacapture/MoreQuestionnaireItemComponents.kt 80.00% <0.00%> (-5.72%) ⬇️
...ws/QuestionnaireItemDatePickerViewHolderFactory.kt 35.93% <0.00%> (-0.58%) ⬇️
...uestionnaireItemDateTimePickerViewHolderFactory.kt 21.92% <0.00%> (ø)
...ndroid/fhir/datacapture/utilities/MoreLocalDate.kt 66.66% <62.50%> (-8.34%) ⬇️
...c/main/java/com/google/android/fhir/sync/Config.kt 65.21% <0.00%> (-29.52%) ⬇️
...n/java/com/google/android/fhir/sync/SyncJobImpl.kt 50.00% <0.00%> (-3.49%) ⬇️
...ews/barcode/mlkit/md/camera/CameraSourcePreview.kt 41.79% <0.00%> (-1.50%) ⬇️
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 90.19% <0.00%> (-0.29%) ⬇️
...com/google/android/fhir/db/impl/dao/ResourceDao.kt 83.18% <0.00%> (ø)
...gle/android/fhir/db/DatabaseEncryptionException.kt 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5273132...59c204e. Read the comment docs.

@jingtang10
Copy link
Collaborator

@santosh-pingle can you take a look at this first? thanks

@santosh-pingle
Copy link
Collaborator

looking into it.

Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some screenshots?

Added comments, please see whether those can be addressed.

@PallaviGanorkar
Copy link
Contributor Author

Can you please add some screenshots?

I put some comments, please see whether those can be addressed.
DateEntryFormatFromJson
DateEntryFormatFromDeviceLocale

@PallaviGanorkar
Copy link
Contributor Author

Can you please add some screenshots?

I put some comments, please see whether those can be addressed.

Added screen shot

@santosh-pingle
Copy link
Collaborator

santosh-pingle commented Mar 30, 2022

Done with first review, looks ok to me. thanks!
Code owner please review it!

@santosh-pingle santosh-pingle self-requested a review March 30, 2022 12:07
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the 3 changes in the PR description, 1 and 2 can probably be grouped in this PR. But please raise a different PR for 3. thanks!

@PallaviGanorkar
Copy link
Contributor Author

As per comment crate two separate PR for this change

@jingtang10 jingtang10 deleted the 1083-973-DatePickerPop branch July 1, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Datacapture, date picker doesn't open after cancel date picker dialog on same field
3 participants