Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "reference" with "demo" in PR Template #1207

Merged
merged 4 commits into from
Feb 25, 2022

Conversation

omarismail94
Copy link
Contributor

Nit fix. Since folder is called demo now, replaced mention of reference with demo

Copy link
Contributor

@vvikramraj vvikramraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you have triggered my OCD, can you please also add full stops to these sentences? :)

@omarismail94
Copy link
Contributor Author

@vvikramraj fixed!

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1207 (1cb1e36) into master (27cfe1f) will decrease coverage by 0.04%.
The diff coverage is 68.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1207      +/-   ##
============================================
- Coverage     84.57%   84.53%   -0.05%     
- Complexity      632      646      +14     
============================================
  Files           135      140       +5     
  Lines         10407    10488      +81     
  Branches        787      795       +8     
============================================
+ Hits           8802     8866      +64     
- Misses         1209     1223      +14     
- Partials        396      399       +3     
Impacted Files Coverage Δ
...ava/com/google/android/fhir/impl/FhirEngineImpl.kt 42.00% <24.13%> (-31.34%) ⬇️
...oid/fhir/sync/bundle/TransactionBundleGenerator.kt 77.27% <77.27%> (ø)
.../google/android/fhir/sync/bundle/BundleUploader.kt 77.77% <77.77%> (ø)
...a/com/google/android/fhir/sync/FhirSynchronizer.kt 81.57% <80.00%> (+14.54%) ⬆️
...ndle/HttpVerbBasedBundleEntryComponentGenerator.kt 90.90% <90.90%> (ø)
...android/fhir/db/impl/entities/LocalChangeEntity.kt 100.00% <100.00%> (ø)
...main/java/com/google/android/fhir/sync/Uploader.kt 100.00% <100.00%> (ø)
...ttpVerbBasedBundleEntryComponentImplementations.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de92a42...1cb1e36. Read the comment docs.

@omarismail94 omarismail94 merged commit 1ee392e into master Feb 25, 2022
@omarismail94 omarismail94 deleted the omarismail94-patch-2 branch February 25, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants