Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page component overlapping issue. #1184

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Landing page component overlapping issue. #1184

merged 2 commits into from
Feb 22, 2022

Conversation

santosh-pingle
Copy link
Collaborator

@santosh-pingle santosh-pingle commented Feb 21, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1112

Description
Devices with small resolution and dpi/ppi, component grids were overlapping on each other.
Instead of giving hard coded value as per figma, match parent value is provided as width.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Bug fix

Screenshots (if applicable)

Screen Shot 2022-02-21 at 5 57 37 PM

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@jingtang10 jingtang10 enabled auto-merge (squash) February 22, 2022 11:48
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1184 (f9b414b) into master (825e047) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1184   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
  Complexity      627      627           
=========================================
  Files           135      135           
  Lines         10404    10404           
  Branches        786      786           
=========================================
  Hits           8799     8799           
  Misses         1210     1210           
  Partials        395      395           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825e047...f9b414b. Read the comment docs.

@jingtang10 jingtang10 merged commit 25d0a63 into master Feb 22, 2022
@jingtang10 jingtang10 deleted the sp/issue-1112 branch February 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component cards in the SDC Catalog app are touching (no gap in between)
2 participants